On Tue, 22 Oct 2024 20:55:30 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> test/jdk/javax/swing/JEditorPane/8080972/TestJEditor.java line 49: >> >>> 47: SwingUtilities.invokeAndWait(TestJEditor::testJEditorPane); >>> 48: } >>> 49: >> >> Is there any need to catch the exception and rethrow RuntimeException below? >> I think we can remove try-catch block altogether... > > Updated Fixed in https://github.com/openjdk/jdk/pull/21498/commits/d9ee496f7349cb8beaf1e696fd430f8064baee8e >> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 117: >> >>> 115: } >>> 116: popup.setVisible(false); >>> 117: frame.dispose(); >> >> The error condition is checked and exception thrown before disposing the >> frame and popup, guess this 2 should be in finally block.. > > Updated Fixed in https://github.com/openjdk/jdk/pull/21498/commits/d9ee496f7349cb8beaf1e696fd430f8064baee8e ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819100037 PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819104451
