On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> We've had logging library maintainers on the core-libs-dev several times in 
>> the last 7+ years so I hope there is good awareness of StackWalker. 
>> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024.
>
> Ok, I'll also add an API note to `getClassContext()` to use `StackWalker` 
> instead.

Okay, it already has `@see StackWalker`. My guess is that anything extending SM 
to call getClassContext is very old code. If that old code is compiled with JDK 
17+ then they should get a warning. In any case, we replaced the implementation 
to use StackWalker so getClassContext will continue to work until the SM class 
is removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1804151450

Reply via email to