On Wed, 16 Oct 2024 08:00:48 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Disallow NotifyFramePop for 
>> enter/enter0/VirtualThread.run/VThreadContinuation.run
>
> src/java.base/share/classes/java/lang/VirtualThread.java line 423:
> 
>> 421:                 }
>> 422: 
>> 423:             } finally {
> 
> This means an empty finally block, I assume you'll remove the try-finally 
> here.

Thank you for the comment. I can move the try-finally to the method 
`java/lang/VirtualThread$VThreadContinuation$1.run()` if you prefer. But it 
will play the same role functionally.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1802799611

Reply via email to