On Tue, 15 Oct 2024 10:12:21 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org> wrote:
> Passing "-Xmx1g -Xcomp" to the LingeredApp. > Testing: tier1 We have 3 processes here: 1. The test. 2. The SA Debuggee process spawned by the test (LingeredApp) 3. The SA "tool", also spawned by the test. (1) and (2) will automatically get the default test args, which will include -Xcomp if it is a -Xcomp test task. (3) will not get the default test args since it is spawned with createLimitedTestJavaProcessBuilder(), which is likely what we want. The only process that needs to be run with -Xcomp (and any other test args) is (2) the debuggee process, but I don't see why we don't just allow it to get -Xcomp when run as part of a -Xcomp test task, and not have -Xcomp otherwise. It doesn't appear that -Xcomp on the debuggee is a requirement for this test, because in the past it has not been explicitly run with -Xcomp. The changes in the PR get rid of test runs where the debuggee does not use -Xcmp, and also continue to force -Xcomp on the test process, which is unnecessary. If we really only want the debuggee run with -Xcomp, then we should probably limit this test to only support -Xcomp test runs. So that means adding `@requires vm.compMode == "Xcomp"`. It also means getting rid of -Xcomp elsewhere in the test. I'm not sure of the reason for `-Xmx1g`. Maybe @tkrodriguez can explain. I think another options is to have the test explicitly launch the debuggee with -Xcomp as is done in this PR, but also add `@requires vm.flagless`. @lmesnik? ------------- PR Review: https://git.openjdk.org/jdk/pull/21519#pullrequestreview-2370566945
