On Tue, 1 Oct 2024 15:38:56 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all,
>> Test `com/sun/tools/attach/PermissionTest.java` fails access denied after
>> [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). This testcase
>> need the `readlink` permission of file `/proc/self/ns/mnt` after
>> [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114).
>> So this PR add `readlink` permission to make this test work normally.
>> Before this PR, test run failed, after this PR, test run success. Test fix
>> only, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> merge two comments enclosed with /* ... */ on two lines
test/jdk/com/sun/tools/attach/java.policy.allow line 17:
> 15:
> 16: /* to read configuration file in META-INF/services, write/delete
> .attach_pid<pid>,
> 17: and read symbolic link of /proc/self/ns/mnt */
Suggestion:
/*
* To read configuration file in META-INF/services, write/delete
.attach_pid<pid>,
* and read symbolic link of /proc/self/ns/mnt.
*/
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21269#discussion_r1783539848
