On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl <d...@openjdk.org> wrote:

>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid 
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains eight additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 
> 8327114-attach-from-container-to-container
>  - Clarify PID 1 check with comment
>  - Adapt code style
>  - Add test for the elevated privileges case
>  - Remove unused `SELF_PID_NS`
>  - Rewrite in line with suggestion from Larry Cable
>  - Reworked attach logic
>  - 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid 
> (Kubernetes debug container)

Sorry for this. I'm happy to look into the 
`com/sun/tools/attach/PermissionTest.java` if you can provide more details 
about the failure (and the environment it fails in).

Is this something that should have failed in GHA checks too?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2385274397
PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2385279008

Reply via email to