On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org>
wrote:
> Cleaning up nsk.share.Log code after the verbose mode was set always true.
>
> Tested all the vmTestbase/ tests.
test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 264:
> 262:
> 263: /**
> 264: * Print <code>message</code> to the assigned output stream,
Need replace the comma with a period.
test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 287:
> 285: if (!verbose()) {
> 286: doPrint(message);
> 287: }
Is this method ever called? Is there a CR to remove it (and any references to
it)?
test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 340:
> 338:
> 339: /**
> 340: * Redirect log to the given <code>stream</code>
Need period at end of sentence.
test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 342:
> 340: * Redirect log to the given <code>stream</code>
> 341: * Prints errors summary to current stream, cancel current stream
> 342: * and switches to new stream.
Does it really do all this? It looks to me like it just switches to the new
stream. I'm not sure what is meant by "error summary" and cancelling.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1781735358
PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1781735837
PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1781737610
PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1781738427
