On Wed, 18 Sep 2024 23:59:39 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> yes, but there is ongoing effort (at Oracle) to get rid of >> ```Klass::_prototype_header``` altogether. Let's wait for that and see how >> it looks then. > > Yes, I saw that patch. I'm not sure I like the idea of cpu dependent code > also doing the encoding. There were some C2 changes related to it that I > didn't understand if that scheme required them. I don't see the down side to > having the prototype header pre-encoded in the markWord. Seems simpler. We already have a cpu dependent code for both C1 and the interpreter. Adding cpu dependent code to C2 doesn't make it significantly worse. My latest patch also refactors the code so that C1, interpreter, and C2 all calls into shared functions in the macro assembler. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1766163092
