On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke <sto...@openjdk.org> wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) >> to Windows. >> >> System.map and System.dump_map are implemented using the Windows API and >> provide roughly the same information in the same format. Most of the heavy >> lifting was implemented by @tstuefe in #16301 - this PR adds the Windows >> implementation and enables the common code for Windows 64 bit. >> >> [Sample output (with NMT >> enabled)](https://github.com/user-attachments/files/16982072/sample_windows_map.txt) > > Simon Tooke has updated the pull request incrementally with one additional > commit since the last revision: > > remove trailing whitespace The build failure happens when the build is configured with '--disable-precompiled-headers'. FWIW, I recommend that everyone who make changes to HotSpot make sure to use that configure flag. I wish that it was the default build configuration, maybe it is time to change this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20597#issuecomment-2358262303
