On Fri, 13 Sep 2024 06:12:04 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> This is a trivial point fix for the `strace` tests to add in the missing 
>> event (super)constructors. These tests have started failing more regularly 
>> after the `Thread.sleep` code was recently changed.
>> 
>> The fragility of these tests is well known but I simply want to deal with 
>> current failures in our CI. It remains a future RFE to fix these tests so 
>> they don't need continual updating like this.
>> 
>> Testing:
>>  - themselves
>>  - tier 5 (which is where we see CI failures most often)
>> 
>> Thanks
>
> So no change to 
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java and 
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/SleepingThread.java 
> this time?
> 
> Is there a JBS issue to re-write these tests?

Thanks for the review @AlanBateman . You are right the others should be updated 
too even though we have never seen the constructor appear in those cases.

I couldn't find a JBS issue so filed 
[JDK-8340088](https://bugs.openjdk.org/browse/JDK-8340088)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20980#issuecomment-2348160557

Reply via email to