On Sat, 7 Sep 2024 05:27:12 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. >> >> `MEMFLAGS` implies that we can use more than one at the same time, but those >> are exclusive values, so `MemTag` is a more suitable name. >> >> This fix also includes a cleanup of all the related parameter names and >> local variable names. >> >> Testing is pending... >> >> Note: there is more history in old closed PRs >> [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) >> and >> [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472) > > src/hotspot/share/utilities/chunkedList.hpp line 31: > >> 29: #include "utilities/debug.hpp" >> 30: >> 31: template <class T, MemTag F> class ChunkedList : public CHeapObj<F> { > > Parameter name should be updated. Suggest `mem_tag`. How about MT here or just M? I would make this a further change though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20872#discussion_r1750281203
