On Fri, 6 Sep 2024 18:56:32 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> Field watch tests updated to be executed with virtual threads when virtual > test thread factory enabled.I added > jdk.test.lib.thread.TestThreadFactory > to created test threads so they support virtual thread factory jtreg plugin. > > It might makes sense to use it in different tests so virtual threads are > tests more extensively. > There is JDIThreadFactory in nsk/sharejdi which I copied. I am going to > update JDI tests to use jdk.test.lib.thread.TestThreadFactory > later. Other than the copyright fix, looks good. test/lib/jdk/test/lib/thread/TestThreadFactory.java line 2: > 1: /* > 2: * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights > reserved. Should just be 2024. ------------- PR Review: https://git.openjdk.org/jdk/pull/20897#pullrequestreview-2287057473 PR Review Comment: https://git.openjdk.org/jdk/pull/20897#discussion_r1747644216
