On Wed, 28 Aug 2024 03:42:27 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

> I'm not sure why this is failing. Based on the existing code and comments, it 
> seems at some point SA worked without relying on the windbg native symbol 
> support. Code like isSharingEnabled() probably got added afterwards and was 
> never tested with it disabled.

It seems the `isSharingEnabled()` has a bug and does not always work with the 
option`Dsun.jvm.hotspot.debugger.windbg.disableNativeLookup=yes"`.
So, there are two choices:
 - use this work around from Alex (with a potential overhead because of extra 
calls to `GetOffsetByName()`)
 - fix the `isSharingEnabled()` related bug and use `GetOffsetByName()` instead 
of native lookup

I wonder if the call to`GetOffsetByName()` can be done with some additional 
check, so it is not always called.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20684#issuecomment-2316309859

Reply via email to