On Thu, 15 Aug 2024 22:06:14 GMT, Dhamoder Nalla <dhana...@openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 1522:
>> 
>>> 1520: const char* os::get_temp_directory() {
>>> 1521:   static char path_buf[MAX_PATH];
>>> 1522:   if (_GetTempPath2A != nullptr) {
>> 
>> Where does _GetTempPath2A get initialized?
>
> Thanks @plummercj for reviewing this PR. Fixed the missing initialization.

FYI I'm not familiar with these Windows APIs, so I probably won't give this 
review approval myself. I only took a look because there was an svc file 
involved (AttachProviderImpl.c). Hopefully others with a better understanding 
of the changes will provide reviews.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20600#discussion_r1719063072

Reply via email to