On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`. > > `MEMFLAGS` implies that we can use more than one at the same time, but those > are exclusive values, so `MemType` is much more suitable name. > > There is a bunch of other related cleanup that we can do, but I will leave > for follow up issues such as [NMT: rename NMTUtil::flag to > NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836) We already have `NMT_TrackingLevel` in `nmtCommon.hpp`, so we could do `NMT_MemType` ? We could also add NMT class and then have `NMT::MemType`? Note that as Stefan pointed out, we refer to it as memory type in memflags.hpp Moreover, we use 'mt' in the actual enumerated names as in `mtNone` for example. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2291520592
