On Mon, 12 Aug 2024 22:40:06 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missing DEBUG_ONLY
>
> src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp line 632:
>
>> 630: bool success = false;
>> 631: if (LockingMode == LM_LEGACY) {
>> 632: // Traditional lightweight locking.
>
> The if-statement is for legacy locking so the comment about lightweight
> locking seems wrong.
Yeah. It is an old comment from before LM_LIGHTWEIGHT existed. Will change to
call it fast locking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716348558
