On Thu, 1 Aug 2024 14:25:47 GMT, Sonia Zaldana Calles <szald...@openjdk.org> 
wrote:

> Hi all, 
> 
> This PR addresses [8337667](https://bugs.openjdk.org/browse/JDK-8337667) . 
> 
> The `Compiler.perfmap` test case is failing on mac and windows as it is only 
> enabled in linux. I am removing this test case and noting that this use case 
> is already tested in 
> [test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java#L88)
>  which is linux specific.
> 
> Thanks, 
> Sonia

test/jdk/sun/tools/jcmd/TestJcmdPIDSubstitution.java line 50:

> 48:         verifyOutputFilenames("Thread.dump_to_file", FILENAME);
> 49:         verifyOutputFilenames("GC.heap_dump", FILENAME);
> 50:         verifyOutputFilenames("Compiler.perfmap", FILENAME);

FWIW this could have been guarded by a platform check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20421#discussion_r1704675379

Reply via email to