On Sat, 3 Aug 2024 03:22:06 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> The test has been fixed to:
>> - add a guard against JVMTI_ERROR_WRONG_PHASE
>> - replace `exit(err)` with `abort()` in the `check_jvmti_error()`
>>
>> The JVMTI `VMDeath` event is enabled and a `RawMonitor` is introduced to
>> serialize `ClassPrepare` and `VMDeath` events, and so, to prevent
>> JVMTI_ERROR_WRONG_PHASE in the `ClassPrepare` events.
>>
>> Testing:
>> - run the test AllowedFunctions.java locally
>> - TBD: submit a mach5 run for fixed test
>
> Serguei Spitsyn has updated the pull request incrementally with one
> additional commit since the last revision:
>
> tweeked comment in ClassPrepare event callback
test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c
line 363:
> 361: check_jvmti_error(jvmti, "ClassPrepare event: Failed in
> RawMonitorEnter", err);
> 362:
> 363: if (is_vm_dead == JNI_TRUE) {
Suggestion:
if (is_vm_dead) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20397#discussion_r1702452004
