On Thu, 1 Aug 2024 05:25:53 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rearranged to have one JvmtiVTMSTransitionDisabler instead of two
>
> src/hotspot/share/prims/jvmtiEventController.cpp line 988:
>
>> 986: (*count_addr)++;
>> 987: if (*count_addr == 1) {
>> 988: JvmtiVTMSTransitionDisabler disabler;
>
> Could you just declare this outside the if-block rather than repeating it?
Thank you for looking at this and for the suggestion, David.
I wanted to optimize a little bit but agree it is not worth it, so updated now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20413#discussion_r1699840543
