On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> CmdLine::is_executable() looks wrong, surely an empty line is not executable. > > With this change, in DCmd::parse_and_execute() we will avoid needlessly > entering the code block to try and execute the command. > > DCmd tests all good: > make images test TEST="test/hotspot/jtreg/serviceability/dcmd > test/jdk/sun/tools/jcmd" This pull request has now been integrated. Changeset: 0325ab8d Author: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/0325ab8d2353f29ac40ff4b028cbc29bff40c59b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8335610: DiagnosticFramework: CmdLine::is_executable() correction Reviewed-by: dholmes, jsjolen ------------- PR: https://git.openjdk.org/jdk/pull/20006