On Fri, 19 Jul 2024 20:17:46 GMT, Sonia Zaldana Calles <szald...@openjdk.org> wrote:
>> Hi all, >> >> This is a small patch to address >> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making >> `CodeCache::write_perf_map` aware of which output stream errors and warning >> message should be going to. >> >> Testing: >> - [x] Added test case passes. >> >> Thanks, >> Sonia > > Sonia Zaldana Calles has updated the pull request incrementally with one > additional commit since the last revision: > > Ensuring test case deletes file in case of exception src/hotspot/share/code/codeCache.hpp line 226: > 224: static void print_summary(outputStream* st, bool detailed = true); // > Prints a summary of the code cache usage > 225: static void log_state(outputStream* st); > 226: LINUX_ONLY(static void write_perf_map(const char* filename, > outputStream* st);) Please add a comment about what the stream `st` is supposed to be. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20257#discussion_r1685374253