On Wed, 17 Jul 2024 14:07:55 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updating copyright headers
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1138:
>
>> 1136: stringStream msg;
>> 1137: msg.print("Invalid file path name specified: %s",
>> _filepath.value());
>> 1138: THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(),
>> msg.base());
>
> write to output() and return instead of throwing
Yes, the error needs to be written the stream so that it is printed by the tool
(at the end other of the pipe).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20198#discussion_r1681352690
