On Sat, 13 Jul 2024 00:39:02 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 79:
>
>> 77: // Value length exceeds 1K.
>> 78: Test withLongValue() {
>> 79: flagValue = generateValue(1024 + 1);
>
> Shouldn't we also be testing exactly 1024 and expect it to work?
good question!
tried to make it 1024 and it does not work!
Windows VirtualMachineImpl has one more issue - it uses 1024 char buffers, but
it should be (1024 + 1) as AttachListener does (1 extra char to 0-terminator),
so maximum argument size on windows is 1023.
Will fix it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19780#discussion_r1676663900
