On Mon, 8 Jul 2024 11:06:45 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> Unfortunately those 2 tests fail now on Linux Alpine (x86_64) : > serviceability/dcmd/vm/SystemDumpMapTest.java > > Missing patterns in dump: > 0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[rwsxp-]+ +\\d+ +\\d+ > +(4K|8K|16K|64K|2M|16M|64M) +com.*\[vdso\] > test SystemDumpMapTest.jmx(): failure > java.lang.RuntimeException: java.lang.RuntimeException: Missing patterns > at SystemDumpMapTest.run_test(SystemDumpMapTest.java:100) > at SystemDumpMapTest.run(SystemDumpMapTest.java:106) > at SystemDumpMapTest.jmx(SystemDumpMapTest.java:112) > at > java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > at > org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) > at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599) > at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174) > at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46) > at > org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822) > at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147) > at > org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128) > at java.base/java.util.ArrayList.forEach(ArrayList.java:1597) > .... > > Reason is that the vdso lib is not there on all Linux flavors; e.g. we do not > seem to have it on our Alpine Linux test system. > So better avoid the check because it is based on false assumptions. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20072#pullrequestreview-2166005745