On Thu, 4 Jul 2024 10:08:30 GMT, Kevin Walls <kev...@openjdk.org> wrote:

> There are two similarly names tests.
> Recently:
> JDK-8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed 
> with CPU time out of expected range
> ...made a simple change to try and avoid noisy test failures.  The same fix 
> should be applied here to ThreadCpuTime.java.
> 
> Also removing an old comment about a Solaris issue.

test/jdk/java/lang/management/ThreadMXBean/ThreadCpuTime.java line 239:

> 237:                     " > ThreadUserTime = " + utime2);
> 238:             }
> 239: */

Shouldn't this be uncommented and this bit of testing restored? It seems the 
only reason it was commented out is because of Solaris, which we don't need to 
worry about anymore. Probably best to leave this to a separate PR if you are 
going to restore it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20025#discussion_r1669075901

Reply via email to