On Sat, 8 Jun 2024 18:05:36 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The nsk.share.Log has 3 parameters that might be configured by tests or > using command-line: > - verbose, traceLevel and timestamp > > The main purpose of these modes was to minimize output and use command-line > arguments to enable them during bug reproducing/debugging for vmTestbase when > it was compiled separately. > > However, such an approach has several disadvantages: > -- For intermittent issues, there is no all data in the logs > -- The enabling log might affect test behavior > -- No easy way to set these command-line options for jtreg tests > -- When verbose mode is disabled the messages are saved in some buffer and > printed only test complains. The mode causes issues if the test fails without > complaining (exception, crash, etc). The messages are just never printed. > -- the solution is over-complicated. > > The fix enabled verbose mode and printing time stamps always, setting the > debugging log level. > > The plan is to remove all these options and simplify logging as much as > possible in the future. This pull request has now been integrated. Changeset: 8464ce6d Author: Leonid Mesnik <lmes...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/8464ce6db5cbd5d50ac2a2bcba905b7255f510f5 Stats: 10 lines in 1 file changed: 0 ins; 4 del; 6 mod 8332113: Update nsk.share.Log to be always verbose Reviewed-by: sspitsyn, cjplummer ------------- PR: https://git.openjdk.org/jdk/pull/19613
