On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas <cslu...@openjdk.org> wrote:

> Please, consider this patch to remove unused methods from the code base. To 
> the best of my knowledge, these methods are only defined but never used.
> 
> Here is a list with names of delete methods: 
> https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874
> 
> Tested with Linux x86_64 tier1-4, GHA, and only cross building to other 
> platforms.

This seems to me like a classic case of not reading the instructions. 
@JohnTortugo, please read the [OpenJDK Developers' 
Guide](https://openjdk.org/guide/) before posting a PR with a huge change. 
There are sections in there that covers this exact case. The section 
[Contributing to an OpenJDK 
Project](https://openjdk.org/guide/#contributing-to-an-openjdk-project) really 
is mandatory reading before doing anything in OpenJDK.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19550#issuecomment-2154820179

Reply via email to