On Mon, 3 Jun 2024 23:02:28 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The fix removes finalization cleanup from vmTestbase.
>> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
>> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
>> debuggee process. So the DebugeeProcess.waitFor() is the good place to close
>> binder and free all it's resources.
>> The SocketIOPipe is used directly in AOD tests where it should be closed
>> after test execution.
>>
>> The OPipe (child of SocketIOPipe) also used in jdi and jdwp tests where it
>> is connected directly in tests. However is also connected with debuggee and
>> could be closed in DebugeeProcess.waitFor().
>>
>> The VMOutOfMemoryException001 test is fixed to release some memory after
>> throwing OOME so Sytem.exit() could complete successfully. Previously some
>> memory freed during VM shutdown hook.
>>
>> I verified that cleanup printed that corresponding 'close' method has been
>> already called before VM shutdown phase for debugger process.
>> Additionally, run all vmTestbase tests to verify there are no failures,
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved return out of try/catch
test/hotspot/jtreg/vmTestbase/nsk/jdi/VMOutOfMemoryException/VMOutOfMemoryException001/VMOutOfMemoryException001t.java
line 50:
> 48: } catch (OutOfMemoryError e) {
> 49: isOutOfMemory = true;
> 50: buf = null;
Do you think maybe it is worth logging "Got OOME" or something like that? Also,
I think this could use a comment, and `buf` could use a more descriptive name.
Maybe "reservedMem".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19505#discussion_r1625192562
