On Wed, 29 May 2024 18:12:25 GMT, Sonia Zaldana Calles <szald...@openjdk.org> wrote:
> Hi folks, > > This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785) > replacing all naked uses for ```UseSharedSpaces``` with > ```CDSConfig::is_using_archive```. > > Testing: > - [x] Tier 1 with GHA. > > Thanks, > Sonia One minor nit but otherwise looks good. Thanks src/hotspot/share/cds/cdsConfig.cpp line 308: > 306: > 307: bool CDSConfig::has_unsupported_runtime_module_options() { > 308: assert(CDSConfig::is_using_archive(), "this function is only used with > -Xshare:{on,auto}"); Nit: you shouldn't need to specify `CDSConfig::` ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19463#pullrequestreview-2089898352 PR Review Comment: https://git.openjdk.org/jdk/pull/19463#discussion_r1621718062
