On Sat, 18 May 2024 09:07:18 GMT, Lei Zaakjyu <d...@openjdk.org> wrote:
>> follow up 8267941 > > Lei Zaakjyu has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains one new > commit since the last revision: > > restore Changes requested by cjplummer (Reviewer). test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsHumongous.java line 90: > 88: // before dumping the string table. That means the heap should > contain no > 89: // humongous regions. > 90: dumpOutput.shouldNotMatch("gc,region,cds. G1HeapRegion > 0x[0-9a-f]* HUM"); Just a minor nit. I noticed a pre-existing typo on line 87 above. It says "kelp" instead of "kept". Can you fix it? ------------- PR Review: https://git.openjdk.org/jdk/pull/18871#pullrequestreview-2067620880 PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1607694956