On Sun, 12 May 2024 21:34:41 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The nsk.share.Log doing some cleanup and reporting errors in the cleanup > method. This method is supposed to be executed by finalizer originally. > However, now it is called only during shutdown hook. > The cleanup using Cleaner doesn't work. See > https://bugs.openjdk.org/browse/JDK-8330760 > > The cleanup() method flush stream and print summary which should be already > printed by complain method. > > This cleanup is not necessary and printing summary usually is just disabled. > It is enabled if the test called 'complain' method. However, the error should > have been printed already in this method. > > So it would be simple to remove this cleanup and reduce usage of Finalizable > in vmTestbase tests. > > Note: The 'verboseOnErrorEnabled' is just not used. > > See isVerboseOnErrorEnabled. > > public boolean isVerboseOnErrorEnabled() { > return errorsSummaryEnabled; > } > > > Tested with by running tests with different combinations (tier4-7) and tier1. Please, not that shutdown hook is not compatible with jtreg agentvm execution. Really, it is not the recommended to use System.exit() and do something after main() in jtreg. Even in main/othervm mode jtreg call class using some wrapper. This worked differently in previous in tonga and need to be adopted. So the plan is to remove such cleanup as much as possible. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19209#issuecomment-2108091553
