On Mon, 13 May 2024 14:21:35 GMT, Evgeny Astigeevich <eastigeev...@openjdk.org> wrote:
> > Are there any high severity problems caused by the original PR? Especially > > not in the new functionality. Minor issues could be probably addressed > > without backing out the entire functionality. > > > > Yes, there are: > > > > > 1. Usually directives are updated for a small number of Java methods. If > > CodeCache has thousands of nmethods, > > CodeCache::recompile_marked_directives_matches will be traversing nmethods > > most of which don't need recompilation. > > > 2. has_matching_directives might not be cleared. > > > 3. A Java method is not recompiled as requested. > > So there are cases when new functionality doesn't work as expected (I don't see any other users impacted). Why not file bugs for those cases and estimate their impact? ------------- PR Comment: https://git.openjdk.org/jdk/pull/19215#issuecomment-2107777980
