On Tue, 9 Apr 2024 01:18:35 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure`
>> classes were introduced in the JDK 22 to unify/simplify the JVM TI functions
>> supporting implementation of the virtual threads. This enhancement is to
>> refactor JVM TI functions `PopFrame` and `ForceEarlyReturn` on the base of
>> `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes.
>>
>> Testing:
>>
>> Ran mach5 tiers 1-6
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 503:
>
>> 501: _value(value),
>> 502: _tos(tos) {}
>> 503: void doit(Thread *target, bool self);
>
> No need to use self, you might use _self from doit().
Good suggestion, thanks.
The UpdateForPopTopFrameClosure::doit has the same issue. Fixed both now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18570#discussion_r1558367607
