On Tue, 2 Apr 2024 22:20:12 GMT, Patricio Chilano Mateo
<pchilanom...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: cleanup - removed temporary logging used for debugging
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1986:
>
>> 1984: jvmtiError err =
>> JvmtiEnvBase::get_threadOop_and_JavaThread(tlh.list(), target, &java_thread,
>> &thread_obj);
>> 1985: if (err != JVMTI_ERROR_NONE) {
>> 1986: printf("DBG: JvmtiHandshake::execute: err: %d\n", (int)err);
>> fflush(0);
>
> Any reason why not use UL instead with jvmti tag?
Nice catch. The `printf` was temporarily used for debugging. Removed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18574#discussion_r1548752419
