On Tue, 2 Apr 2024 00:40:37 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The fix updated HeapDumper to always perform merge on the current thread. > > Testing: tier1-5, all HeapDump-related tests > Covered heap dumping scenarios: > - `jcmd GC.heap_dump` command; > - `HotSpotDiagnosticMXBean.dumpHeap()`; > - `HeapDumpBeforeFullGC`, `HeapDumpAfterFullGC` VM options; > - `HeapDumpOnOutOfMemoryError` VM option. Marked as reviewed by sspitsyn (Reviewer). This looks good and simpler to me. src/hotspot/share/services/heapDumper.cpp line 2648: > 2646: > 2647: DumpMerger merger(path, &writer, dumper.dump_seq()); > 2648: // perform heapdump file merge operation in the current thread > prevents us Nit: Better to start with a capital letter. ------------- PR Review: https://git.openjdk.org/jdk/pull/18571#pullrequestreview-1974986347 PR Comment: https://git.openjdk.org/jdk/pull/18571#issuecomment-2033059611 PR Review Comment: https://git.openjdk.org/jdk/pull/18571#discussion_r1548582212
