On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadStats()` along with the > implementation method in `HotspotCompilation` > * The class returned by these methods, `CompilerThreadStat` > * The nested class `HotspotCompilation.CompilerThreadInfo` which now falls > out of use > * The field `HotspotCompilation.threads`, along with its initialization in > `initCompilerCounters` > > This was initially discussed here: > https://mail.openjdk.org/pipermail/serviceability-dev/2024-March/054589.html > > Testing and verification: As this is purely a removal and cleanup PR of > unused code, no updates are made on the testing side. I have verified that > the string `getCompilerThreadStats` is not found in OpenJDK after this PR. Yes, looks good. No problems with testst in test/jdk/javax/management or test/jdk/sun/management. ------------- Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18344#pullrequestreview-1945428269
