On Mon, 11 Mar 2024 18:23:25 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 26 commits: >> >> - Merge >> - review: minor tweak in test description of ObjectMonitorUsage.java >> - review: addressed more comments on the fix and new test >> - rename after merge: jvmti_common.h to jvmti_common.hpp >> - Merge >> - review: update comment in threads.hpp >> - fix deadlock with carrier threads starvation in ObjectMonitorUsage test >> - resolve merge conflict for deleted file objmonusage003.cpp >> - fix a typo in libObjectMonitorUsage.cpp >> - fix potential sync gap in the test ObjectMonitorUsage >> - ... and 16 more: https://git.openjdk.org/jdk/compare/de428daf...b97b8205 > > test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage001/TestDescription.java > line 46: > >> 44: * @library /vmTestbase >> 45: * /test/lib >> 46: * @run main/othervm/native -agentlib:objmonusage001=printdump >> nsk.jvmti.GetObjectMonitorUsage.objmonusage001 > > I only included this `=printdump` for debug when I was updating the test. > You don't have to keep it. Thanks, removed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1520736552