On Mon, 11 Mar 2024 18:43:11 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 26 commits: >> >> - Merge >> - review: minor tweak in test description of ObjectMonitorUsage.java >> - review: addressed more comments on the fix and new test >> - rename after merge: jvmti_common.h to jvmti_common.hpp >> - Merge >> - review: update comment in threads.hpp >> - fix deadlock with carrier threads starvation in ObjectMonitorUsage test >> - resolve merge conflict for deleted file objmonusage003.cpp >> - fix a typo in libObjectMonitorUsage.cpp >> - fix potential sync gap in the test ObjectMonitorUsage >> - ... and 16 more: https://git.openjdk.org/jdk/compare/de428daf...b97b8205 > > test/hotspot/jtreg/serviceability/jvmti/ObjectMonitorUsage/libObjectMonitorUsage.cpp > line 202: > >> 200: LOG("(%d) notify_waiter_count expected: %d, actually: %d\n", >> 201: check_idx, notifyWaiterCount, inf.notify_waiter_count); >> 202: result = STATUS_FAILED; > > Please consider prefixing these LOG output lines with "FAILED:" so that it > is easier to identify the log output where failure info is shown. Good suggestion. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1520726685
