On Fri, 9 Feb 2024 20:42:14 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> The fix adds check that merged constant pool does not overflow u2 (two-byte 
>> unsigned).
>> The check is added after merging `the_class` and `scratch_class` constant 
>> pools, but before rewriting constant pool references.
>> 
>> testing:
>>  - sanity tier1;
>>  - all RedefineClasses/RetransformClasses tests:
>>    - test/jdk/java/lang/instrument
>>    - test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
>>    - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
>>    - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   logging on cp overflow

Yes, this should definitely be tagged noreg-hard.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17759#pullrequestreview-1873283771

Reply via email to