On Mon, 22 Jan 2024 23:37:35 GMT, John R Rose <jr...@openjdk.org> wrote:
>> src/hotspot/share/runtime/globals.hpp line 2013: >> >>> 2011: "Profile exception handlers") >>> \ >>> 2012: >>> \ >>> 2013: product(bool, AlwaysRecordEvolDependencies, true, DIAGNOSTIC, >>> \ >> >> As we record all dependencies not only evol_method ones, should we name it >> just: `AlwaysRecordDependencies`? > > That’s not exactly right either. `RecordAllDependencies` would be more like > it. Because: > > - We might record some dependencies that we know we need, and leave others > out. > - Or, we might record all dependencies, even ones we think we might not > need. > > (But we will need them all if somebody turns on JFR.) > > I like this change. Having a diagnostic switch means we can do a rough > triage if something seems to go wrong with this change, down the road. No, because you want to turn on/off evol_method independently of the other dependencies that the compiler is recording. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17509#discussion_r1462556836
