On Sat, 20 Jan 2024 19:48:07 GMT, Volker Simonis <simo...@openjdk.org> wrote:
> Instead of unconditionally recording evol_method dependencies we could guard > the recording by a new flag. But this would only make sense if that flag > would be on by default and I don't know if such a flag is justified just for > the rare (or non-existent?) cases where somebody wants to disable the > recording of the dependencies. I think introducing a diagnostic flag is sensible here. If we figure out much later that this solution comes with some other (worse) problems, the diagnostic flag gives us the options to: a) clearly point at this addition as the culprit; b) have the easily deployable solution to restore the original behavior. For the change itself, we need to amend the comment near `VM_RedefineClasses::flush_dependent_code` definition that talks about this peculiar behavior, which now changes. Actually, maybe even the implementation of `flush_dependent_code` should now trust (and assert) that all dependencies are now recorded? ------------- PR Comment: https://git.openjdk.org/jdk/pull/17509#issuecomment-1904382556
