On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu <d...@openjdk.org> wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Changes requested by kbarrett (Reviewer).
src/hotspot/share/gc/serial/serialHeap.cpp line 105:
> 103: _eden_pool(nullptr),
> 104: _survivor_pool(nullptr),
> 105: _old_pool(nullptr) {
Don't make this change to the indentation of the mem-initializer-list. The
existing indentation is one of
several styles used in GC code, including throughtout Z. The proposed new
indentation is one which is
also probably still used in older code. But some time ago there was discussion
amongst the Oracle GC
team about constructor formatting and which of several we might prefer. We
didn't reach a consensus
at the time, but this one was unanimously, and strongly, disliked. The problem
is that with the indentation
of the mem-initializer-list being the same as the body, and the opening brace
of the body cuddled with
the end of the mem-initializer-list, it is hard to spot where the
mem-initializer-list ends and the body
begins.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17398#pullrequestreview-1820092218
PR Review Comment: https://git.openjdk.org/jdk/pull/17398#discussion_r1451597990
