On Thu, 4 Jan 2024 02:06:28 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> In threadControl.c, at build time you can decide to keep track of thread > names by compiling with "#define DEBUG_THREADNAME". If this is also a debug > build, some extra debugging functions are included in the build, including > "dumpThread(ThreadNode *node)". These are intended to be called from gdb, or > possibly from somewhere in the debug agent implementation, to aid with > debugging. When dumpThread() prints the thread's name, it just uses the name > that was stored when the thread was created. However, the thread name can > change, so dumpThread() should really fetch the current thread name and print > it. > > I also added some commented out code to print other useful fields of the > ThreadNode, including the ThreadState. These can be enabled by the user as > needed. > > Tested with all of tier1, and also ran tier2 and tier4 svc tests. src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 2654: > 2652: jvmtiError error = FUNC_PTR(gdata->jvmti,GetThreadState) > 2653: (gdata->jvmti, node->thread, &state); > 2654: return state; Nit: The indent in this file is 4, not 2. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17259#discussion_r1443245407
