On Thu, 30 Nov 2023 08:42:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Please review this simple clarification to the JVM TI spec regarding use of >> `JAVA_TOOL_OPTIONS` in regards to module options and their format. >> >> I do not believe this clarification needs a CSR request. >> >> Thanks. > > src/hotspot/share/prims/jvmti.xml line 746: > >> 744: <code>JNI_CreateJavaVM</code> (in the JNI Invocation API) will >> prepend these options to the options supplied >> 745: in its <code>JavaVMInitArgs</code> argument. Note that module >> related options must be expressed in their >> 746: "option=value" form (not "option value") for >> <code>JNI_CreateJavaVM</code> to process them correctly. > > This looks okay. I'm just comparing it to the text that we put into the JNI > spec: > > "The module related options ... as option strings using their "option=value" > format instead of their "option value" format. (Note the required = between > "option" and "value".)" > > It uses "format" instead of "form" and also, the bit I think works well, is > to point the out the "required =" to force the reader to re-read the previous > sentence and see what the difference is in the formats. The JNI version looks a little better. :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16896#discussion_r1411233376
