On Thu, 30 Nov 2023 02:45:45 GMT, Jonathan Joo <j...@openjdk.org> wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing include
src/hotspot/share/runtime/cpuTimeCounters.cpp line 47:
> 45: return "conc_dedup";
> 46: default:
> 47: ShouldNotReachHere();
My IDE complained and I guess depending on warning level we might need a return
here.
Suggestion:
ShouldNotReachHere();
return "";
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1410454940
