On Thu, 23 Nov 2023 12:43:00 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup and address comments
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2433:
>
>> 2431: }
>> 2432: WorkerThreads* worker_threads = workers();
>> 2433: if (worker_threads != nullptr) {
>
> When will this be null?
I guess it shouldn't be, since it is set when we call initialize() and also
never unset. I'll remove this conditional.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1410005989
