On Mon, 27 Nov 2023 20:59:54 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> I would agree, it should state if runtime functions (including those doing a >> syscall) will be counted here. (For JNi i would not need it to be spelled >> out, on the other hand it would help, since it makes clear we don’t mean c2 >> code) > > This `isInNative` method intends to provide a way to tell if the thread has > transitioned from executing Java method to a native method. JVM interpreter > and compiler provide the support for Java language which is why I think such > clarification might not be highly necessary. FWIW I would not remove the "does not include ..." information otherwise people may wrongly infer that in the past this method would not return true for VM code or generated code, but that now it does. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16791#discussion_r1407259421
