> This is a docs only change to j.l.management.ThreadInfo::isInNative. 
> 
> The method currently specifies that it tests if the thread is  "executing 
> native code via the Java Native Interface (JNI)".  It would be clearer to say 
> that it tests if the thread is executing a native method, and expand it to 
> include native code invoked using the new foreign linker APIs. For now, I've 
> left out the detail of a downcall handle created with the "critical" linker 
> option.
> 
> The existing javadoc has wording to try to clarify that "native code" does 
> not include runtime or compiled code. I went through a few iterations to work 
> this in but all attempts just invite more questions and nit picking. To keep 
> it simple, this sentence is dropped so that the method description is focused 
> on the cases where the method returns true.

Alan Bateman has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains five additional commits since 
the last revision:

 - Change link to downcallHandle
 - Merge
 - Simplify wording
 - Merge
 - Initial commit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16791/files
  - new: https://git.openjdk.org/jdk/pull/16791/files/93ac45a6..5e2cc189

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16791&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16791&range=00-01

  Stats: 3366 lines in 72 files changed: 2233 ins; 606 del; 527 mod
  Patch: https://git.openjdk.org/jdk/pull/16791.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16791/head:pull/16791

PR: https://git.openjdk.org/jdk/pull/16791

Reply via email to