On Thu, 23 Nov 2023 11:00:32 GMT, Afshin Zafari <azaf...@openjdk.org> wrote:

> > Thanks for making this change.
> > I'd like to suggest the following cleanups, some documentation, and a few 
> > tests: 
> > [20d4502](https://github.com/openjdk/jdk/commit/20d4502471ba396ae395512cfa3dab3f87555421)
> > I think it might be easier to review by looking at the final diff: 
> > [master...stefank:jdk:pr_15418](https://github.com/openjdk/jdk/compare/master...stefank:jdk:pr_15418)
> 
> One question: the `private static bool by_name(const char* name, PerfData* 
> pd);` is added to `PerfDataList` class but is never used. Is something 
> missing?

That should have been removed when I added name_equals.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1824302304

Reply via email to