On Sat, 18 Nov 2023 01:37:21 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: add jdk_internal_vm_Continuation::done(cont) check to >> JvmtiEnvBase::is_vthread_alive > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 631: > >> 629: return !jdk_internal_vm_Continuation::done(cont) && >> 630: java_lang_VirtualThread::state(vt) != >> java_lang_VirtualThread::NEW && >> 631: java_lang_VirtualThread::state(vt) != >> java_lang_VirtualThread::TERMINATED; > > AFAIU `jdk_internal_vm_Continuation::done(cont)` is correct check that > vthread is terminated and works for both mounted and unmounted vthreads. > Then `java_lang_VirtualThread::state(vt) != > java_lang_VirtualThread::TERMINATED` check is not needed Good suggestion, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16460#discussion_r1398219250
